Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR relaxes the hardcoded libclang dependency to support environments where the library is exposed under the generic name clang, which better accommodates newer libclang versions and packaging differences.
Changes:
- Update the FFI binding for
FFIGenerate::Clang::Cto load eitherclang-15or the genericclanglibrary name, tryingclang-15first for backwards compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support newer
libclanglibrary versions.Currently libclang v15 is hardcoded so this won't work for any other libclang version.
But actually libclang is backwards compatible so
ruby_ffi_generatorworks fine even with newer libclang versions.I have
libclangv21.1.6installed and it works fine without any issues. No code changes needed.This is benefit of using FFI interface because C ABI is very stable (unlike C++ ABI).